-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stratified report fix #315
Conversation
Coverage report
Test suite run success459 tests passing in 31 suites. Report generated by 🧪jest coverage report action from a3c69d3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm just one small inline comment! Also, could be worth adding something about the potential prescence of stratifierResults on episodeResults? Either in the Stratification Section or Measure With Observation Function Section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥳
Summary
Addresses UnexpectedProperty issue in #311.
New behavior
For episode-based measures with stratifiers, (as was already done for patient-based), we now default the
strataCode
to be the id if thestrata.code?.text
does not existCode changes
DetailedResultsBuilder.ts
- defaultsstrataCode
tostrata.id
as secondary preferred value for episode resultsMeasureReportBuilder.ts
- slight efficiency improvement and added clarifying commentDetailedResultsBuilder.test.ts
anMeasureReportBuilder.test.ts
Testing guidance
npm run check
fqm-execution details -m "path\to\measures\EpisodeMeasure.json" -p "path\to\patients\Episode_Patient.json" -o "path\to\output\Episode_Details.json" --vs-api-key {apiKey}